Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: first praise -> activate #1070

Merged
merged 12 commits into from
Jun 30, 2023
Merged

feat: first praise -> activate #1070

merged 12 commits into from
Jun 30, 2023

Conversation

Vyvy-vi
Copy link
Collaborator

@Vyvy-vi Vyvy-vi commented Jun 9, 2023

fixes #1048

@kristoferlund kristoferlund self-requested a review June 13, 2023 14:01
kristoferlund
kristoferlund previously requested changes Jun 13, 2023
View reviewed changes
Copy link
Member

@kristoferlund kristoferlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flow worked great!

If pressing retry before account has been activated, the bot gives you a confirmation as if command had completed and the crashes.

image

And, I think it is ok to have a timeout on the retry button as long as user is notified in a good way.

kristoferlund
kristoferlund requested changes Jun 30, 2023
View reviewed changes
Copy link
Member

@kristoferlund kristoferlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retry message was sent twice when I reviewed this.

image
  1. Try praising
  2. Bot says: "In order to dish.. "
  3. I click "RETRY", bot answers with "Retry failed"
  4. I go to website and activate
  5. I click "RETRY" again
  6. Praise is sent.. and "Retry failed" message is printed again.

@Vyvy-vi
Copy link
Collaborator Author

Vyvy-vi commented Jun 30, 2023

@kristoferlund I've made the needed changes.

kristoferlund
kristoferlund approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@kristoferlund kristoferlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this will greatly simplify the onboarding process.

@kristoferlund kristoferlund merged commit a5c7bb6 into main Jun 30, 2023
4 checks passed
@kristoferlund kristoferlund deleted the feat/1048/first-activation branch June 30, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoferlund kristoferlund kristoferlund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Activate account when praising the first time
2 participants
@Vyvy-vi @kristoferlund